fix(v4.0.0-beta.4): demo trading wss should only be used for private …

…connections
tiagosiebler · Feb 6, 2025 · a8f8d6b · a8f8d6b
2 parents d051142 + 646fecc
commit a8f8d6b
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/examples/ws-public-v5.ts b/examples/ws-public-v5.ts
@@ -17,7 +17,12 @@ const logger = {
  * - Heartbeats/ping/pong/reconnects are all handled automatically.
  *    If a connection drops, the client will clean it up, respawn a fresh connection and resubscribe for you.
  */
-const wsClient = new WebsocketClient({}, logger);
+const wsClient = new WebsocketClient(
+  {
+    // demoTrading: true,
+  },
+  logger,
+);
 
 wsClient.on('update', (data) => {
   console.log('raw message received ', JSON.stringify(data));

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "bybit-api",
-  "version": "4.0.0-beta.3",
+  "version": "4.0.0-beta.4",
   "description": "Complete & robust Node.js SDK for Bybit's REST APIs and WebSockets, with TypeScript & strong end to end tests.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

diff --git a/src/util/websockets/websocket-util.ts b/src/util/websockets/websocket-util.ts
@@ -241,7 +241,7 @@ export function getWsUrl(
   }
 
   // https://bybit-exchange.github.io/docs/v5/demo
-  const demoTradingPrivateEndpoint = 'wss://stream-demo.bybit.com/v5/private';
+  const DEMO_TRADING_ENDPOINT = 'wss://stream-demo.bybit.com/v5/private';
 
   const isDemoTrading = wsClientOptions.demoTrading;
   const isTestnet = wsClientOptions.testnet;
@@ -250,13 +250,13 @@ export function getWsUrl(
   switch (wsKey) {
     case WS_KEY_MAP.v5Private: {
       if (isDemoTrading) {
-        return demoTradingPrivateEndpoint;
+        return DEMO_TRADING_ENDPOINT;
       }
       return WS_BASE_URL_MAP.v5.private[networkKey];
     }
     case WS_KEY_MAP.v5PrivateTrade: {
       if (isDemoTrading) {
-        return demoTradingPrivateEndpoint;
+        return DEMO_TRADING_ENDPOINT;
       }
       return WS_BASE_URL_MAP[wsKey].private[networkKey];
     }