fix(4.0.0-beta.1): fix backwards compatibility with req_id usage for …

…ws subscribe/unsubscribe
tiagosiebler · Jan 24, 2025 · 8a69214 · 8a69214
1 parent 86fc739
commit 8a69214
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "bybit-api",
-  "version": "4.0.0-beta.0",
+  "version": "4.0.0-beta.1",
   "description": "Complete & robust Node.js SDK for Bybit's REST APIs and WebSockets, with TypeScript & strong end to end tests.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

diff --git a/src/util/BaseRestClient.ts b/src/util/BaseRestClient.ts
@@ -4,7 +4,6 @@ import https from 'https';
 
 import {
   APIID,
-  REST_CLIENT_TYPE_ENUM,
   RestClientOptions,
   RestClientType,
   getRestBaseUrl,

diff --git a/src/websocket-client.ts b/src/websocket-client.ts
@@ -550,10 +550,18 @@ export class WebsocketClient extends BaseWebsocketClient<
 
     switch (market) {
       case 'all': {
+        const topics = requests.map((r) => r.topic);
+
+        // Previously used to track topics in a request. Keeping this for subscribe/unsubscribe requests, no need for incremental values
+        const req_id =
+          ['subscribe', 'unsubscribe'].includes(operation) && topics.length
+            ? topics.join('_')
+            : this.getNewRequestId();
+
         const wsEvent: WsRequestOperationBybit<WsTopic> = {
-          req_id: this.getNewRequestId(),
+          req_id: req_id,
           op: operation,
-          args: requests.map((r) => r.topic),
+          args: topics,
         };
 
         const midflightWsEvent: MidflightWsRequestEvent<