Skip to content

Commit

Permalink
feat(v3.10.32): add params for GetDeliveryRecord, fixed e2e tests
Browse files Browse the repository at this point in the history
  • Loading branch information
JJ-Cro committed Feb 10, 2025
1 parent 646fecc commit 1abc242
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 15 deletions.
23 changes: 11 additions & 12 deletions .github/workflows/e2etest.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
name: 'Build & Test'
name: E2ETests # Changed to match KuCoin naming

on: [push]

# on:
# # pull_request:
# # branches:
# # - "master"
# push:
# branches:
on:
push:
pull_request: # Added pull_request trigger
workflow_dispatch: # Added manual trigger option

jobs:
build:
E2ETests: # Changed job ID to match KuCoin
name: 'Build & Test'
runs-on: ubuntu-latest

Expand All @@ -30,8 +26,11 @@ jobs:
- name: Build
run: npm run build

- name: Test
run: npm run test
- name: Test Public API Calls # Split test command into public and private
run: npm run test -- public.test.ts

- name: Test Private API Calls # Added separate step for private API tests
run: npm run test -- private.test.ts
env:
API_KEY_COM: ${{ secrets.API_KEY_COM }}
API_SECRET_COM: ${{ secrets.API_SECRET_COM }}
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "bybit-api",
"version": "3.10.31",
"version": "3.10.32",
"description": "Complete & robust Node.js SDK for Bybit's REST APIs and WebSockets, with TypeScript & strong end to end tests.",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
2 changes: 2 additions & 0 deletions src/types/request/v5-asset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ export interface GetCoinExchangeRecordParamsV5 {
export interface GetDeliveryRecordParamsV5 {
category: CategoryV5;
symbol?: string;
startTime?: number;
endTime?: number;
expDate?: string;
limit?: number;
cursor?: string;
Expand Down

0 comments on commit 1abc242

Please sign in to comment.