Open
Conversation
Author
|
I should also mention, this PR probably only makes sense once #11 is completed. If that issue brings anything new that might need adjustment in this PR (like another string that needs to be localized) I'll happily take care of that. |
Author
|
@mandybess Great, I just made my adjustments to make it work with the changes and pushed them into the PR! Awesome work with the app btw, I'm so happy to now have my beloved metric units as well :) |
Author
|
@mandybess Oh and seeing that Tropos is now also available outside the US through the Play Store - if you want to have the Play Store listing match the app by giving it a proper German translation hit me up, I'd be happy to work with you on that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to make a localized German version of the app for myself, and decided to push the changes I made back upstream, in case you're interested :)
🔧 Changes
📝 Notes
I've added a test that runs with the
dequalifier and checks the summary for the German equivalent of "It's the same this afternoon as yesterday afternoon."This test should succeed when ran in PST, but right now, the test fails for me, because I'm in a timezone where the
1484180189timestamp is actually during the night, so the summary changes accordingly - which is correct behavior, but the tests are not setup to deal with timezone differences. This is actually making a few other tests fail as well.@mandybess I feel like fixing this should be a separate issue, and not part of this PR, right?