Add option to install local build #1241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+30
to
+31
| elsif ARGV.include?("--suspenders-local") && ENV["SUSPENDERS_LOCAL_PATH"] | ||
| gem "suspenders", path: ENV.fetch("SUSPENDERS_LOCAL_PATH") |
There was a problem hiding this comment.
This feels a little redundant. Would this be better?
Suggested change
| elsif ARGV.include?("--suspenders-local") && ENV["SUSPENDERS_LOCAL_PATH"] | |
| gem "suspenders", path: ENV.fetch("SUSPENDERS_LOCAL_PATH") | |
| elsif ENV["SUSPENDERS_LOCAL_PATH"].present? | |
| gem "suspenders", path: ENV.fetch("SUSPENDERS_LOCAL_PATH") |
Then, we could omit --suspenders-local altogether.
SUSPENDERS_LOCAL_PATH=/path/to/suspenders \
rails new app_name \
--skip-rubocop \
--skip-test \
-d=postgresql \
-m=https://raw.githubusercontent.com/thoughtbot/suspenders/main/lib/install/web.rb
In the process of supporting Rails 8 via #1213, we realized we needed to install a local build. This commit simply introduces a `--suspenders-local` option, and documents how to build locally. Co-Authored-By: Nick Charlton <[email protected]>
stevepolitodesign
force-pushed
the
sp-update-contributing-guide
branch
from
ae32054 to
c69f21a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of supporting Rails 8 via #1213, we realized we needed to
install a local build.
This commit simply introduces a
--suspenders-localoption, anddocuments how to build locally.