Styles Generator: Install postcss-url
#1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1190 When including styles from `node_modules` via `@import`, we discovered that static assets referenced in those style sheets are not loaded, resulting in console errors. Since [cssbundling-rails][] ships with [postcss-import][], we are already encouraging the use of importing styles from `node_modules`. This commit aims to solve this problem by installing and configuring [postcss-url][]. Because `postcss-url` needs a directory to copy assets to, we create `app/assets/static` as part of the generator. One thing to note is that we override the `postcss.config.js` generated by the cssbundling-rails installation script, which assumes that the following plugins have been installed. - `postcss-import` - `postcss-nesting` - `autoprefixer` Should that change, this file would be invalid, and those packages would need to be installed. [cssbundling-rails]: https://github.com/rails/cssbundling-rails [postcss-import]: https://github.com/postcss/postcss-import [postcss-url]: https://github.com/postcss/postcss-url
| end | ||
|
|
||
| def configures_postcss | ||
| File.delete(postcss_config) if File.exist?(postcss_config) |
There was a problem hiding this comment.
Unfortunately, copy_file does not override existing files. So, we need to delete it first.
Closed
stevepolitodesign
added a commit
that referenced
this pull request
May 10, 2024
Closes #1190 When including styles from `node_modules` via `@import`, we discovered that static assets referenced in those style sheets are not loaded, resulting in console errors. Since [cssbundling-rails][] ships with [postcss-import][], we are already encouraging the use of importing styles from `node_modules`. This commit aims to solve this problem by installing and configuring [postcss-url][]. Because `postcss-url` needs a directory to copy assets to, we create `app/assets/static` as part of the generator. One thing to note is that we override the `postcss.config.js` generated by the cssbundling-rails installation script, which assumes that the following plugins have been installed. - `postcss-import` - `postcss-nesting` - `autoprefixer` Should that change, this file would be invalid, and those packages would need to be installed. [cssbundling-rails]: https://github.com/rails/cssbundling-rails [postcss-import]: https://github.com/postcss/postcss-import [postcss-url]: https://github.com/postcss/postcss-url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1190
When including styles from
node_modulesvia@import, we discovered that static assets referenced in those style sheets are not loaded, resulting in console errors.Since cssbundling-rails ships with postcss-import, we are already encouraging the use of importing styles from
node_modules.This commit aims to solve this problem by installing and configuring postcss-url. Because
postcss-urlneeds a directory to copy assets to, we createapp/assets/staticas part of the generator.One thing to note is that we override the
postcss.config.jsgenerated by the cssbundling-rails installation script, which assumes that the following plugins have been installed.postcss-importpostcss-nestingautoprefixerShould that change, this file would be invalid, and those packages would need to be installed.