Open
Conversation
Before, there was no guidance for using Roux within a Rails project. Rails 8 uses Propshaft by default, which doesn't support CSS `@import`. This, plus the peformance impact make a bundler required rather than optional. Now, a new "Using Roux with Rails" section in the README explains the constraint and links to a new guides/rails-setup.md with step-by-step instructions and a defensive shell script that skips steps already completed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, there was no guidance for using Roux within a Rails project.
Rails 8 uses Propshaft by default, which doesn't support CSS
@import. This, plus the peformance impact make a bundler required rather than optional.Now, a new "Using Roux with Rails" section in the README explains the constraint and links to a new guides/rails-setup.md with step-by-step instructions and a defensive shell script that skips steps already completed.
@enatario I went for a separate setup file as it felt like the script was making the readme too long. I'm not precious about any of this so feel to completely rewrite to suit your style :)
Closes #12