Skip to content

Commit

Permalink
Upgrade base Ruby to 3.4.1 and add to test matrix (#2734)
Browse files Browse the repository at this point in the history
We also add `mutex_m` and `drb`, as Rails 6.1 fails on Ruby 3.4 without
it. Those gems have been moved out of Ruby core.

https://www.ruby-lang.org/en/news/2024/12/25/ruby-3-4-0-released/
  • Loading branch information
nickcharlton authored Dec 31, 2024
1 parent 6032177 commit d5c3c56
Show file tree
Hide file tree
Showing 11 changed files with 15 additions and 11 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [3.2, 3.3]
ruby: [3.2, 3.3, 3.4]
env:
PGHOST: localhost
PGUSER: administrate
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [3.1, 3.2, 3.3]
ruby: [3.1, 3.2, 3.3, 3.4]
appraisal: [rails61, rails70, rails80, pundit21]
include:
- ruby: '3.0'
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.2
3.4.1
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ruby 3.2.2
ruby 3.4.1
nodejs 20.11.0
yarn 1.22.22
2 changes: 2 additions & 0 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ appraise "rails60" do
end

appraise "rails61" do
gem "drb"
gem "mutex_m"
gem "rails", "~> 6.1"
end

Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
source "https://rubygems.org"
ruby "3.2.2" unless ENV["CI"] && !ENV["DIFF_CHECK_APPRAISAL"]
ruby "3.4.1" unless ENV["CI"] && !ENV["DIFF_CHECK_APPRAISAL"]

gemspec

Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ DEPENDENCIES
yard

RUBY VERSION
ruby 3.2.2p53
ruby 3.4.1p0

BUNDLED WITH
2.4.22
2 changes: 1 addition & 1 deletion gemfiles/pundit21.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

ruby "3.2.2"
ruby "3.4.1"

gem "administrate-field-image"
gem "faker"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails60.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

ruby "3.2.2"
ruby "3.4.1"

gem "administrate-field-image"
gem "faker"
Expand Down
4 changes: 3 additions & 1 deletion gemfiles/rails61.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

ruby "3.2.2"
ruby "3.4.1"

gem "administrate-field-image"
gem "faker"
Expand All @@ -19,6 +19,8 @@ gem "unicorn"
gem "cssbundling-rails", "~> 1.4"
gem "jsbundling-rails", "~> 1.3"
gem "sprockets-rails", "~> 3.5"
gem "drb"
gem "mutex_m"
gem "rails", "~> 6.1"

group :development, :test do
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails70.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

ruby "3.2.2"
ruby "3.4.1"

gem "administrate-field-image"
gem "faker"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails80.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

ruby "3.2.2"
ruby "3.4.1"

gem "administrate-field-image"
gem "faker"
Expand Down

0 comments on commit d5c3c56

Please sign in to comment.