Expandasearch #3433
Open
Expandasearch #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into expandasearch
…into expandasearch
thorsten
requested changes
Apr 2, 2025
| @@ -29,9 +29,11 @@ export const handleExpandaSearch = (): void => { | |||
| if (s && s.querySelector('button')) s.querySelector('button').disabled = false; | |||
| if (s && s.querySelector('input')) s.querySelector('input').focus(); | |||
| document.querySelector('div.searchContainer')!.style.width = "90%"; | |||
| redoTimeout(); | |||
| } | |||
|
|
|||
| function hideSearch(e?: MouseEvent): void { | |||
There was a problem hiding this comment.
A better naming would be awesome, so please use event instead of just an e
…into expandasearch
…into expandasearch
|
Better now?
…On Wed, Apr 2, 2025 at 5:57 PM Thorsten Rinne ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In phpmyfaq/assets/src/search/expandasearch.ts
<#3433 (comment)>:
> @@ -29,9 +29,11 @@ export const handleExpandaSearch = (): void => {
if (s && s.querySelector('button')) s.querySelector('button').disabled = false;
if (s && s.querySelector('input')) s.querySelector('input').focus();
document.querySelector('div.searchContainer')!.style.width = "90%";
+ redoTimeout();
}
function hideSearch(e?: MouseEvent): void {
A better naming would be awesome, so please use event instead of just an e
—
Reply to this email directly, view it on GitHub
<#3433 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEU3PCC6W5NZS2SHVPDFWL2XQCFPAVCNFSM6AAAAAB2FQJU3SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMZWHAYTSNRZGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@sniemetz Could you please fix the merge conflict? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move search box into top nav and hide it on search.html
add search link to nav for smaller screens