chore: code cleanup

thorsten · Feb 10, 2025 · 0eb85e5 · 0eb85e5
1 parent 0662639
commit 0eb85e5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 22 deletions.
diff --git a/phpmyfaq/src/phpMyFAQ/Controller/Administration/ElasticsearchController.php b/phpmyfaq/src/phpMyFAQ/Controller/Administration/ElasticsearchController.php
@@ -23,7 +23,6 @@
 use phpMyFAQ\Core\Exception;
 use phpMyFAQ\Enums\PermissionType;
 use phpMyFAQ\Faq;
-use phpMyFAQ\Instance\Elasticsearch;
 use phpMyFAQ\Translation;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Response;

diff --git a/phpmyfaq/src/phpMyFAQ/Controller/Administration/ExportController.php b/phpmyfaq/src/phpMyFAQ/Controller/Administration/ExportController.php
@@ -21,7 +21,6 @@
 use phpMyFAQ\Administration\HttpStreamer;
 use phpMyFAQ\Administration\Report;
 use phpMyFAQ\Category;
-use phpMyFAQ\Configuration;
 use phpMyFAQ\Controller\AbstractController;
 use phpMyFAQ\Core\Exception;
 use phpMyFAQ\Enums\PermissionType;

diff --git a/phpmyfaq/src/phpMyFAQ/Controller/Administration/FormController.php b/phpmyfaq/src/phpMyFAQ/Controller/Administration/FormController.php
@@ -27,11 +27,12 @@
 use phpMyFAQ\Session\Token;
 use phpMyFAQ\Forms;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Attribute\Route;
 
 class FormController extends AbstractController
 {
     #[Route('admin/api/forms/activate')]
-    public function activateInput(Request $request)
+    public function activateInput(Request $request): JsonResponse
     {
         $this->userHasPermission(PermissionType::FORMS_EDIT);
         $data = json_decode($request->getContent());
@@ -53,7 +54,7 @@ public function activateInput(Request $request)
     }
 
     #[Route('admin/api/forms/required')]
-    public function setInputAsRequired(Request $request)
+    public function setInputAsRequired(Request $request): JsonResponse
     {
         $this->userHasPermission(PermissionType::FORMS_EDIT);
         $data = json_decode($request->getContent());
@@ -75,7 +76,7 @@ public function setInputAsRequired(Request $request)
     }
 
     #[Route('admin/api/forms/translation-edit')]
-    public function editTranslation(Request $request)
+    public function editTranslation(Request $request): JsonResponse
     {
         $this->userHasPermission(PermissionType::FORMS_EDIT);
         $data = json_decode($request->getContent());
@@ -98,7 +99,7 @@ public function editTranslation(Request $request)
     }
 
     #[Route('admin/api/forms/translation-delete')]
-    public function deleteTranslation(Request $request)
+    public function deleteTranslation(Request $request): JsonResponse
     {
         $this->userHasPermission(PermissionType::FORMS_EDIT);
         $data = json_decode($request->getContent());
@@ -122,9 +123,6 @@ public function deleteTranslation(Request $request)
         }
     }
 
-    /**
-     * @throws Exception
-     */
     #[Route('admin/api/forms/translation-add')]
     public function addTranslation(Request $request): JsonResponse
     {

diff --git a/phpmyfaq/src/phpMyFAQ/Controller/Administration/GlossaryController.php b/phpmyfaq/src/phpMyFAQ/Controller/Administration/GlossaryController.php
@@ -18,7 +18,6 @@
 namespace phpMyFAQ\Controller\Administration;
 
 use phpMyFAQ\Controller\AbstractController;
-use phpMyFAQ\Core\Exception;
 use phpMyFAQ\Enums\PermissionType;
 use phpMyFAQ\Filter;
 use phpMyFAQ\Glossary;
@@ -31,9 +30,6 @@
 
 class GlossaryController extends AbstractController
 {
-    /**
-     * @throws Exception
-     */
     #[Route('admin/api/glossary')]
     public function fetch(Request $request): JsonResponse
     {
@@ -48,9 +44,6 @@ public function fetch(Request $request): JsonResponse
         return $this->json($glossary->fetch($glossaryId), Response::HTTP_OK);
     }
 
-    /**
-     * @throws Exception
-     */
     #[Route('admin/api/glossary/delete')]
     public function delete(Request $request): JsonResponse
     {
@@ -75,9 +68,6 @@ public function delete(Request $request): JsonResponse
         }
     }
 
-    /**
-     * @throws Exception
-     */
     #[Route('admin/api/glossary/create')]
     public function create(Request $request): JsonResponse
     {
@@ -103,9 +93,6 @@ public function create(Request $request): JsonResponse
         }
     }
 
-    /**
-     * @throws Exception
-     */
     #[Route('admin/api/glossary/update')]
     public function update(Request $request): JsonResponse
     {