add support for Vox (Amuse Labs compatible) download by date via calendar picker#318
Open
superhawk610 wants to merge 1 commit intothisisparker:mainfrom
Open
add support for Vox (Amuse Labs compatible) download by date via calendar picker#318superhawk610 wants to merge 1 commit intothisisparker:mainfrom
superhawk610 wants to merge 1 commit intothisisparker:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent some time poking around Vox's crossword archive and found that it references
/calendar-picker, in a similar manner to the existing/date-pickerresource used by other Amuse Labs puzzles. This resource doesn't provide JSON-formatted info like the other, but it does allow selecting a year/month via URL parameters, and provides a day->puzzle ID mapping after a bit of HTML parsing.I've used this to implement
find_by_dateforAmuseLabsDownloader, and provided the requiredcalendar_urlfor the Vox downloader. I haven't tested with other Amuse Labs puzzles, but I imagine thatcalendar_urlshouldn't be too hard to find to enable this for others (maybe we should just usepicker_urland replacedate-pickerwithcalendar-picker?To test that this works:
and that missing puzzles are also handled gracefully: