Gracefully skip errors having to do with bad/dead links in iframes#217
Open
dwincort wants to merge 1 commit intothisisparker:mainfrom
Open
Gracefully skip errors having to do with bad/dead links in iframes#217dwincort wants to merge 1 commit intothisisparker:mainfrom
dwincort wants to merge 1 commit intothisisparker:mainfrom
Conversation
dwincort
force-pushed
the
main
branch
3 times, most recently
from
baa4ed5 to
10b2b49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
parse_for_embedded_puzzlefunction, we get a set ofsrcs from iframes. In the event that one of thesesrcs is a bad/dead link (specifically, one that comes before the embedded puzzle we're looking for), thenxword-dlwill throw an error instead of finding the correct iframesrc.This PR resolves this problem by putting the
requests.get(src)in a try-catch block.