Repository level configuration files and minor fixes. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add *.lutconfig files to gitingore.
These files are configurationsfor the live unit testing feature in
Visual Studio and can be safely ignored
global.json file allows the maintainer to control the SDK versioning
explicitely regardless of the SDK version installed on the machine
the code is being looked at or built on.
Add Directory.Build.props and put global solution-wide properties
in that file. the global properties currently selected are:
1. TargetFramework version
2. Nullable flag
3. ImplicitUsings flag
4. TreatWarningsAsErrors flag
5. LangVersion attribute
6. AnalysisLevel attribute
7. Version attribute
Edit all *.csproj files and remove redundant / duplicate properties.
Add Directory.Packages.props file and add all package versions to it
Edit all *.csproj files and delete version attribute from their
referenced packages tags
Reduce AnalysisLevel from latest-all to latest-minimum
Reduce AnalysisMode from all to minimum
Add Directory.Build.props and put global solution-wide properties
in that file. the global properties currently selected are:
1. TargetFramework version
2. Nullable flag
3. ImplicitUsings flag
4. TreatWarningsAsErrors flag
5. LangVersion attribute
6. AnalysisLevel attribute
7. Version attribute
Edit all *.csproj files and remove redundant / duplicate properties.
Add Directory.Packages.props file and add all package versions to it
Edit all *.csproj files and delete version attribute from their
referenced packages tags
Add package version reference for
Microsoft.Extensions.Options.ConfigurationExtensions to
Directory.Packages.props
Add package reference for
Microsoft.Extensions.Options.ConfigurationExtensions to
Infrastructure projct
Ignore the PrimitiveConstructor warning for all projects
Use `List<T>` instead if `IList<T>` for performance reasons.
Ignore some warnings and infos for generated files in Migrations
directory
…d-packages repo/consolidating versioning and packages
|
Thanks Kia, these changes are great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look at the
shortlogfor detailed changes.