Skip to content

Fix TFTP client attacks without generating event issues #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

H-Dynamite
Copy link

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

Fix TFTP client attacks without generating event issues

(filename, mode, ignore) = data[2:].split(b"\x00")

This may have 5 parameters, such as [b '/home', b'octet ', b'blksize', b'512 ', b' '], which cannot be ignored by using' ignore '. I don't know if this is caused by the Python version. I am using Python 3.8.10 and 3.12.9, which do not support the' ignore 'keyword. I use the' * _ 'keyword to ignore it. Solved this problem

Types of changes

What types of changes does your code introduce to this repository?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes (if applicable)
  • I have run pre-commit (pre-commit in the repo)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Linked to the relevant github issue or github discussion

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@H-Dynamite
Copy link
Author

I used two clients, Tftpd64.exe and/tftpp-nowwindows-amd64.exe, for testing . tftp-now-windows-amd64.exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant