-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: REST API to update entity twin data #3425
feat: REST API to update entity twin data #3425
Conversation
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Robot Results
|
57d1501
to
7f8012a
Compare
7f8012a
to
e8a524c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It would be good to implement
tedge http patch
along this PR. - I was expecting the updated twin data to be published over the
twin
topics.
I pushed a commit for that: 4e3e940 |
4e3e940
to
6e7c4c6
Compare
Resolved by 6e7c4c6 |
Oops, this commits has been removed by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will be happy to merge this PR. However, I have first to re-push the commit adding support for tedge http patch
.
}, | ||
} | ||
``` | ||
* 400: Bad Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would give a bit more context on these errors, even if one can guess it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved by 3e94e0e
Done: bece5bc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature.
As discussed, we could build upon this interface and also look at providing a similar API endpoint which mirrors the MQTT twin topic (te/{topic-id}/twin/{type}
) as this would make it easier for users to switch between the MQTT and HTTP interfaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Thin-edge registration over HTTP is now a thing. Nice!
Signed-off-by: Didier Wenzek <[email protected]>
bece5bc
to
89c2e3c
Compare
Proposed changes
REST API to update entity twin data
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments