fix: pin kiosk keyboard to viewport bottom for more search results#187
Merged
fix: pin kiosk keyboard to viewport bottom for more search results#187
Conversation
Move keyboard from inline flow to position:fixed at the bottom of the viewport. Add padding-bottom on the modal to prevent content hiding behind the keyboard. Increase compact search results max-height from 120px to 50vh so 5-6+ results are visible above the keyboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
position: fixedinstead of inline flow inside the modalpadding-bottom: 280pxto the keyboard-active modal to prevent content from being hidden behind the fixed keyboardmax-heightfrom120pxto50vhso 5-6+ results are visible above the keyboardContext
On the kiosk touchscreen, only ~2 search results were visible because the inline keyboard consumed most of the modal's vertical space. By fixing the keyboard to the viewport bottom and letting the search results expand, guests can now see many more results without scrolling.
Test plan
/e/{code}/display→ "Request a Song" → no virtual keyboard, search results display normally