fix: correct keyboard CSS selectors and increase key size for kiosk#185
Merged
fix: correct keyboard CSS selectors and increase key size for kiosk#185
Conversation
CSS overrides were targeting .simple-keyboard but the class doesn't exist when simple-keyboard is instantiated with a DOM element ref. Changed selectors to .kiosk-keyboard (our actual container class). Also increased key height (48→58px) and font size for kiosk touch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.simple-keyboard→.kiosk-keyboardso dark theme overrides actually applyRoot cause
simple-keyboard only adds
.simple-keyboardclass when instantiated with a CSS selector string. When passed a DOM element (our approach via React ref), the container keeps its existing classes (kiosk-keyboard) plus getshg-theme-defaultfrom the theme option. Our overrides targeted.simple-keyboardand matched nothing, so the default light theme showed through.Test plan
🤖 Generated with Claude Code