fix: add CSS class to keyboard container to prevent crash#184
Merged
Conversation
…S_ERROR
simple-keyboard requires the DOM element passed to its constructor to
have at least one CSS class. The bare `<div ref={containerRef} />`
had none, causing an uncaught error that crashed the kiosk display.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
className="kiosk-keyboard"to the<div ref={containerRef} />in KioskKeyboard.tsxKEYBOARD_DOM_CLASS_ERRORwhen the DOM element has no CSS class, crashing the entire display pageRoot cause
simple-keyboardcheckselement.classList.length === 0in its constructor and throws if no class is present. Our bare<div ref={containerRef} />had no class. The error was uncaught, triggering Next.js's client-side error boundary ("Application error").This was not caught in tests because the test mock replaces the real
simple-keyboardconstructor entirely.Test plan
🤖 Generated with Claude Code