add zizmor for linting workflows. #2798
Merged
+37
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NicholasTanz <[email protected]>
jku
requested changes
Feb 20, 2025
There was a problem hiding this comment.
Nice, thanks.
- left one change request: the release workflow is a bit tricky to test but I'm guessing the rc release name is not correct right now. This seems like the only merge blocking thing
- On personas: I believe "auditor" persona is not appropriate but "pedantic" might be -- feel free to experiment if you want but be aware that some of the suggestions might require discussion. Keeping the default is totally fine for this PR though
- The output is a little verbose maybe... Can you fiddle with verbosity settings to get the output to roughly match the other tools (in
tox -e lint) -- one or two lines of output from zizmor would be ideal for successful run
Signed-off-by: NicholasTanz <[email protected]>
switching to pedantic covered all of the suppressed results (5) and they seem fairly reasonable to me 4/5 of them were due to unpinned "uses", but those were all unpinned with the reason that security wasn't critical. I tried using the ignore with the trailing explanation but it didn't seem to work. (Ignoring without explanation worked fine.) 1/5 was due to excessive permissions and even though there's just one job in that workflow, I think it makes sense to specify the permissions in the job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
Fixes #2793