Skip to content

chore: support async connection settings provider #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Amine-H
Copy link

@Amine-H Amine-H commented Jul 1, 2025

Proposed changes

Support async connection settings provider

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Amine-H
Copy link
Author

Amine-H commented Jul 2, 2025

@thetutlage can you please have a look at this PR 🙏🏼

@thetutlage
Copy link
Owner

Can you please share the use-case for this?

@Amine-H
Copy link
Author

Amine-H commented Jul 3, 2025

Can you please share the use-case for this?

A use case would be an async retrieval of DB credentials, especially when the credentials could be rotated at anytime

@Amine-H
Copy link
Author

Amine-H commented Jul 5, 2025

@thetutlage any concerns with these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants