-
Notifications
You must be signed in to change notification settings - Fork 166
🚧 Update mongoid version #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
module Mongoid | ||
module Enum | ||
VERSION = "0.4.0" | ||
VERSION = '0.4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
@@ -1 +1 @@ | |||
require "bundler/gem_tasks" | |||
require 'bundler/gem_tasks' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
expect { |b| Mongoid::Enum.configure &b } | ||
.to yield_with_args Mongoid::Enum.configuration | ||
.to yield_with_args Mongoid::Enum.configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
describe ".configure" do | ||
it "yields configuration if block is given" do | ||
describe '.configure' do | ||
it 'yields configuration if block is given' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
expect(Mongoid::Enum.configuration).to be Mongoid::Enum.configuration | ||
end | ||
end | ||
|
||
describe ".configure" do | ||
it "yields configuration if block is given" do | ||
describe '.configure' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
it "uses the first value" do | ||
describe 'default values' do | ||
context 'when not specified' do | ||
it 'uses the first value' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
context "when not specified" do | ||
it "uses the first value" do | ||
describe 'default values' do | ||
context 'when not specified' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
describe "default values" do | ||
context "when not specified" do | ||
it "uses the first value" do | ||
describe 'default values' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
context "and more than one document" do | ||
it "returns all documents with those values" do | ||
context 'and more than one document' do | ||
it 'returns all documents with those values' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
instance.save | ||
instance.author! | ||
instance.editor! | ||
expect(User.author.to_a).to eq [instance] | ||
end | ||
end | ||
|
||
context "and more than one document" do | ||
it "returns all documents with those values" do | ||
context 'and more than one document' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I currently created a fork for my company just to update the gem version, so it'd be very good if we could update it in the main repo
@thetron could you take a look at this? |
Updated the mongoid gem version for a better compatibility for the new versions.