fix(build): fix tsdown external dependency regex on Windows (#626)#628
Merged
vishxrad merged 1 commit intoJun 10, 2026
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #626.
The existing
neverBundleregex (/^[^./]/) treats Windows drive-letter paths as external dependencies. During Windows builds this leaves local TypeScript imports unresolved in generated output, which later causes@openuidev/browser-bundleto fail with errors such as:This change updates the regex so Windows absolute paths are handled correctly while preserving the existing behavior for package imports.
Changes
Updated the
neverBundleconfiguration in the affectedtsdownconfigs to avoid matching Windows absolute paths.Test Plan
Tested on Windows 11.
pnpm installnow completes successfully and@openuidev/browser-bundlebuilds without the unresolved import errors. I also verified thatpnpm --filter @openuidev/docs devstarts successfully after the change.