Use rimraf in openui-cli template build script#627
Merged
Conversation
Replace fs.rmSync with rimrafSync in build-templates.js for consistency with react-ui and browser-bundle packages. Fixes #625
vishxrad
previously approved these changes
Jun 10, 2026
vishxrad
approved these changes
Jun 10, 2026
4 tasks
ankit-thesys
added a commit
that referenced
this pull request
Jun 10, 2026
….0.8 Version bumps for the first publish since 2026-05-20 (4b663b9): - @openuidev/react-ui 0.11.8 -> 0.12.0 (minor): component CSS now ships in `@layer openui` (#589/#621) and react-syntax-highlighter moved to ^16.1.1 (#577, fixes prismjs CVE-2024-53382) - @openuidev/lang-core 0.2.5 -> 0.2.6 (patch): parser preserves markdown fences and comments inside string props (#605) - @openuidev/cli 0.0.7 -> 0.0.8 (patch): cross-platform template build (#601, #627); no functional changes to the published CLI Remaining packages have no consumer-visible changes since the last publish and are not republished; the lang wrappers pick up lang-core 0.2.6 transitively via their ^0.2.5 ranges. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ankit-thesys
added a commit
that referenced
this pull request
Jun 16, 2026
* chore(release): bump react-ui to 0.12.0, lang-core to 0.2.6, cli to 0.0.8 Version bumps for the first publish since 2026-05-20 (4b663b9): - @openuidev/react-ui 0.11.8 -> 0.12.0 (minor): component CSS now ships in `@layer openui` (#589/#621) and react-syntax-highlighter moved to ^16.1.1 (#577, fixes prismjs CVE-2024-53382) - @openuidev/lang-core 0.2.5 -> 0.2.6 (patch): parser preserves markdown fences and comments inside string props (#605) - @openuidev/cli 0.0.7 -> 0.0.8 (patch): cross-platform template build (#601, #627); no functional changes to the published CLI Remaining packages have no consumer-visible changes since the last publish and are not republished; the lang wrappers pick up lang-core 0.2.6 transitively via their ^0.2.5 ranges. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(react-ui): strip leading BOM before wrapping CSS in @layer openui Sass emits a UTF-8 BOM for compressed output containing non-ASCII characters. At byte 0 the CSS decoder strips it, but wrapInLayer() concatenated the layer prelude in front of it, pushing the BOM inside the block where U+FEFF parses as an identifier: `:root` becomes a type selector that matches nothing, silently killing the first rule. In the packed 0.12.0 tarball this dropped the entire :root theme-token block of dist/components/index.css (and the first rule of dist/styles/index.css and markDownRenderer.css). Verified in Chrome: the BOM-poisoned rule does not apply; subsequent rules are unaffected. Strip the BOM before wrapping. Repacked tarball now has 0 BOMs across all 171 shipped CSS files and the :root block parses correctly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(react-ui): strip leading BOM from unlayered default CSS The opt-in re-land (#631) only strips the BOM when wrapping the layered mirror, so Sass's compressed-mode BOM leaked into the unlayered defaults (components.css, styles/index.css, markDownRenderer.css). A leading BOM is harmless to browsers but breaks the package's zero-BOM contract and would become fatal if those files were ever wrapped. cp-css.js now strips it from the unlayered output, and check-css-artifacts.js asserts the unlayered exports are BOM-free too (the guard previously only checked the layered mirror). Root cause is on main (#631's cp-css.js) — flagged for a follow-up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
fs.rmSyncwithrimrafSyncinpackages/openui-cli/scripts/build-templates.jsfor consistency with thereact-uiandbrowser-bundlepackages, which already userimraf.Fixes #625
Changes
packages/openui-cli/package.json: Addedrimraf(^5.0.7) as a dev dependency, matching the version used byreact-uiandbrowser-bundle.packages/openui-cli/scripts/build-templates.js: Replacedfs.rmSync(destDir, { recursive: true, force: true })withrimrafSync(destDir). Template copy behavior is preserved.Verification
Build succeeds and the template output at
dist/templates/openui-chatis created correctly.