Add SliderBlock component with label, inline editing, and range support - #270
Merged
Merged
Conversation
- Introduce SliderBlock: a high-level slider wrapper with a label header, inline value controls (text Input for continuous, Select dropdown for discrete), range support with two controls, input validation with error messages, and debounced onValueCommit - Merge sliderBlock styles into slider.scss (single file); fix input placement by aligning header items properly and adding flex-start on error state - Disable Input and Select controls when the slider is disabled - Fix SelectItem children to use String(o) so value "0" displays correctly in the trigger - Update genui-lib Slider to render SliderBlock instead of the base Slider, adding optional label prop to the schema - Replace storybook stories with SliderBlock variants (continuous, discrete, range, disabled) - Export SliderBlock from the Slider barrel and dependencies Made-with: Cursor
|
@i-subham23 is attempting to deploy a commit to the thesys-devs Team on Vercel. A member of the Team first needs to authorize it. |
abhithesys
approved these changes
Mar 12, 2026
abhithesys
approved these changes
Mar 12, 2026
…ackage and modify Slider schema to make the label property optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SliderBlockcomponent: A high-level slider wrapper that adds a label header, inline value editing controls (textInputfor continuous mode,Selectdropdown for discrete mode), range support with dual controls, input validation with error messages, and debouncedonValueCommit.SliderBlockinstead of the baseSlider, with an optionallabelprop added to the schema.