Add PrintContext - #244
Merged
Merged
Conversation
Comment on lines
+292
to
+301
| // Read initial dimensions synchronously before first paint to avoid size jump | ||
| useLayoutEffect(() => { | ||
| const wrapper = wrapperRef.current; | ||
| if (!wrapper) return; | ||
|
|
||
| const rect = wrapper.getBoundingClientRect(); | ||
| setWrapperRect({ width: rect.width, height: rect.height }); | ||
| }, []); | ||
|
|
||
| // Use ResizeObserver for subsequent size changes |
Contributor
There was a problem hiding this comment.
why are we doing this ?
Contributor
There was a problem hiding this comment.
and if so why not do the same for radial chart ?
Contributor
Author
There was a problem hiding this comment.
I am using useLayoutEffect to set the wrapper size. This reduces the flickering of the chart.
- Moved the logic to the place we are using resize observer.
- Added the same to radar chart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For printing a component several changes might be required like changing layout, hide something, reveal hidden elements.
This change adds PrintContext, which devs can use to tell components that they are being printed.
All the chart animations have been disabled, when in print context.