Refactor PieChart and RadialChart components to utilize color palette directly - #243
Merged
Conversation
i-subham23
commented
Dec 19, 2025
Contributor
- Updated PieChart and RadialChart components to use a color palette from the theme instead of relying on a default theme string.
- Modified data transformation functions to accept colors as parameters, enhancing flexibility and customization.
- Removed redundant color palette logic from chart configuration functions, streamlining the codebase.
… directly * Updated PieChart and RadialChart components to use a color palette from the theme instead of relying on a default theme string. * Modified data transformation functions to accept colors as parameters, enhancing flexibility and customization. * Removed redundant color palette logic from chart configuration functions, streamlining the codebase.
* Simplified color assignment in RadialChartUtils and dataUtils to enhance clarity and maintainability. * Ensured consistent usage of custom colors for chart elements, improving visual representation.
* Removed palette/distributed colors logic from getCategoricalChartConfig, simplifying the function. * Updated the function signature to accept colors as an array, enhancing flexibility in color assignment for categorical charts.
abhithesys
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.