Added tooltip to area chart , bar chart , line chart #148
Merged
Conversation
i-subham23
requested review from
abhithesys,
ankit-thesys,
rabisg and
thesysHrijul
July 3, 2025 07:09
abhithesys
approved these changes
Jul 3, 2025
ankit-thesys
force-pushed
the
adding-tooltip-to-xAxixTick
branch
from
July 3, 2025 12:45
3242575 to
6fbca7a
Compare
…ult prop handling This commit refactors the LabelTooltipProvider component by extracting default values for delayDuration, skipDelayDuration, and disableHoverableContent into constants. The component is also converted to a functional component for improved readability and maintainability. Additionally, the LabelTooltip component now utilizes the default delayDuration constant, enhancing consistency across the tooltip implementation.
…, and LineChart components This commit enhances the AreaChart, BarChart, and LineChart components by wrapping them with the new LabelTooltipProvider. This integration allows for improved tooltip functionality across these chart components, ensuring a consistent user experience when interacting with chart elements. Additionally, the charts maintain their existing tooltip features while benefiting from the new provider's capabilities.
This commit cleans up the BarChart component by removing a duplicate import statement for the LabelTooltipProvider. This change enhances code clarity and maintains consistency in the import structure.
…gration This commit updates the XAxisTick component to utilize the new LabelTooltip for displaying content. It introduces state management to check for text truncation and conditionally renders the tooltip based on the content's visibility. Additionally, the LabelTooltip component is integrated into both multi-line and angled tick variants, improving user experience by providing contextual information when text is truncated.
This commit removes the "angled" variant from the XAxisTick component, simplifying the implementation by eliminating unnecessary code related to angled text rendering. The XAxisTick type definition is also updated to reflect this change, enhancing clarity and maintainability of the component.
abhithesys
approved these changes
Jul 3, 2025
This commit simplifies the useMaxLabelHeight hook by removing the redundant handling for the "angled" tick variant, as it is no longer necessary following recent refactoring of the XAxisTick component. This change enhances code clarity and maintainability.
ankit-thesys
added a commit
that referenced
this pull request
Jul 3, 2025
This reverts commit 3b2998d.
ankit-thesys
added a commit
that referenced
this pull request
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.