Skip to content

soundwire: lower the trace level to warning when the alert is ignored #5619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bardliao wants to merge 1 commit into
base: topic/sof-dev
Choose a base branch
from
Open

soundwire: lower the trace level to warning when the alert is ignored #5619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions drivers/soundwire/bus.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,8 +1664,12 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave)
/* Read Intstat 1, Intstat 2 and Intstat 3 registers */
ret = sdw_read_no_pm(slave, SDW_SCP_INT1);
if (ret < 0) {
dev_err(&slave->dev,
"SDW_SCP_INT1 read failed:%d\n", ret);
if (ret == -ENODATA)
dev_warn(&slave->dev,
"SDW_SCP_INT1 read command was ignored\n");
else
dev_err(&slave->dev,
"SDW_SCP_INT1 read failed:%d\n", ret);
goto io_err;
}
buf = ret;
Expand Down Expand Up @@ -1959,10 +1963,14 @@ int sdw_handle_slave_status(struct sdw_bus *bus,

case SDW_SLAVE_ALERT:
ret = sdw_handle_slave_alerts(slave);
if (ret < 0)
dev_err(&slave->dev,
"Slave %d alert handling failed: %d\n",
i, ret);
if (ret < 0) {
if (ret == -ENODATA)
dev_warn(&slave->dev,
"Slave %d alert is ignored\n", i);
else
dev_err(&slave->dev,
"Slave %d alert handling failed: %d\n", i, ret);
}
break;

case SDW_SLAVE_ATTACHED:
Expand Down
Loading