Flat Token Design Support & Podspec file#90
Open
callbacknull wants to merge 4 commits intothermogl:masterfrom
Open
Flat Token Design Support & Podspec file#90callbacknull wants to merge 4 commits intothermogl:masterfrom
callbacknull wants to merge 4 commits intothermogl:masterfrom
Conversation
added 3 commits
July 9, 2014 14:53
TIToken's now support a 'flat design' that does not add a gradient to the main body of the token. To use implement: - (BOOL)tokenField: willAddToken: And set your token's tint color and set flat design to YES.
When a flat design token is selected / highlighted the color of the selected state is made either slightly darker or slightly brighter. This is determined based of whether or not the color is a 'dark' color or if it is a 'light' color. A weighted distance of the RGB color space is computed and if the color is greater than 127.5 it is darker. Weighted RGB Brightness formula: brightness=sqrt( .241*R^2 + .691*G^2 + .068*B^2) Added TIToken private methods: - (UIColor *)lighterColorForColor:(UIColor *)c; - (UIColor *)darkerColorForColor:(UIColor *)c; - (BOOL)isColorDarker:(UIColor *)color;
Contributor
Author
|
In TIToken's drawRect: method I'm pretty sure I segregated all the gradient color setting correctly. Well, The results sure look right. But let me know if I may have messed that up and I can fix it. |
Useful if you need to know when a token is being highlighted. For my use case this was useful because of a 'tap to dismiss' checks to see if a token is being highlighted and if it is then it won't dismiss the tokenfield from being the first responder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I've added support for flat color tokens (i.e no gradients). When the token is selected/highlighted the color is adjusted to be either slightly lighter or darker dependent on a weighted brightness of the token's tintcolor. See the image below for an example.
For those who don't know, you can adjust your token's tintColor in the following delegate:
I also added the podspec file as this is fairly standard across pods to have it in the repo. (I would say at least 90% of the pods I've used / looked at have it this way)