Harden Python codegen formatting#160
Merged
Merged
Conversation
|
📖 Documentation Preview: https://reflectapi-docs-preview-pr-160.partly.workers.dev Updated automatically from commit 635290c |
6c9ef0e to
20cf572
Compare
20cf572 to
496030a
Compare
avkonst
reviewed
May 22, 2026
Fail Python codegen when ruff format is requested but Ruff is missing or fails, and make --format=false a working escape hatch. Document Ruff as a formatter dependency and pin the CI Ruff version used by Rust tests.
496030a to
a2c840f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff formatis found but exits non-zero--format=falsea working escape hatch while preserving bare-f/--formatRootModel[tuple[...]]instead of invalid numeric fieldsValidation
cargo fmt --checkcargo test -p reflectapi-clicargo test -p reflectapi --libcargo run -p reflectapi-cli --quiet -- codegen -s reflectapi-demo/reflectapi.json -o /tmp/reflectapi-no-ruff-check-client -l python --python-package-name api_client --python-sync -fwith Ruff absent from PATHcargo test -p reflectapi-demo tests::basic::test_reflectapi_struct_tuple -- --nocapturewith Ruff on PATHcargo test -p reflectapi-demo test_python_split_modules -- --nocapturewith Ruff on PATHcargo test -p reflectapi-demo --test codegen_coverage -- --nocapturewith Ruff on PATHcargo test -p reflectapi-demo tests::write_python_client -- --nocapturewith Ruff on PATH