Fix Python docstring escaping and namespace imports#157
Merged
Conversation
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
|
📖 Documentation Preview: https://reflectapi-docs-preview-pr-157.partly.workers.dev Updated automatically from commit 3512267 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Generated Python clients could fail to import when schemas contained quote-heavy descriptions or when generated type hints crossed split namespace modules. The namespace issue shows up in larger clients where a model references a child or peer namespace before that namespace has been imported and rebound in the package.
Coverage
input, and deferred model rebuilds.Validation
ee6016f: Rust format, lint, and test; Python runtime tests; Python codegen smoke test; documentation examples; and documentation preview all passed. The docs deploy job is skipped as expected for this PR.cargo fmt --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace, and importing the generated demo Python client.Fixes #156.