fix rt-sse feature flag handling and per item error type for event no…#132
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
|
📖 Documentation Preview: https://reflectapi-docs-preview-pr-132.partly.workers.dev Updated automatically from commit dba3bb4 |
hardbyte
added a commit
that referenced
this pull request
May 6, 2026
#132 introduces a separate StreamItemError<NE> for per-item Rust stream errors and gates __stream_request_impl behind the rt-sse feature flag. Update the streaming description in the client docs to: - mention the rt-sse feature requirement on Rust - separate init failures from per-item failures (matches both the post-#132 Rust shape and the existing Python ApplicationError vs ValidationError split) - spell out which Python exceptions the per-event path raises
hardbyte
approved these changes
May 6, 2026
hardbyte
added a commit
that referenced
this pull request
May 6, 2026
#132 introduces a separate StreamItemError<NE> for per-item Rust stream errors and gates __stream_request_impl behind the rt-sse feature flag. Update the streaming description in the client docs to: - mention the rt-sse feature requirement on Rust - separate init failures from per-item failures (matches both the post-#132 Rust shape and the existing Python ApplicationError vs ValidationError split) - spell out which Python exceptions the per-event path raises
hardbyte
added a commit
that referenced
this pull request
May 6, 2026
#132 introduces a separate StreamItemError<NE> for per-item Rust stream errors and gates __stream_request_impl behind the rt-sse feature flag. Update the streaming description in the client docs to: - mention the rt-sse feature requirement on Rust - separate init failures from per-item failures (matches both the post-#132 Rust shape and the existing Python ApplicationError vs ValidationError split) - spell out which Python exceptions the per-event path raises
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tifications