Add too-many-positional-arguments to ignore list for pylint
#214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
=======================================
Coverage ? 94.13%
=======================================
Files ? 11
Lines ? 801
Branches ? 0
=======================================
Hits ? 754
Misses ? 47
Partials ? 0 |
PaulWAyers
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Seems OK to me. Might be good to see if @FarnazH has some thoughts on long lists of positional arguments, but it does seem semi-standard (at least when optional arguments are included) in scientific packages like scipy
|
@FarnazH, do you have any comments or suggestions before I merge it? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the failing test.