Add case when matrix is ill-conditioned for generic procrustes #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixed by adding a small random noise, as discussed in #197.
The
pinv
function is implemented inhttps://github.com/scipy/scipy/blob/4bd5e943cbf30efde4becea48c388faafa14e9e4/scipy/linalg/_basic.py#L1447, which replies on https://github.com/scipy/scipy/blob/4bd5e943cbf30efde4becea48c388faafa14e9e4/scipy/linalg/_decomp_svd.py#L13-L169. The implementation of
pinv
only checks explicitly if the tolerance values are valid.