fix race in refcount#426
Merged
themrdemonized merged 1 commit intothemrdemonized:egerfrom Feb 13, 2026
Merged
Conversation
Owner
|
For resources, i tested atomic counter in MT version before, it lead to severe performance issues. I chose critical section blocking instead for resources, might port it later. str_value does use atomic there |
Contributor
Author
|
i see. feel free to close PR then. warfare mode seems to more extensively use affected lua calls and crashes quite regularly. backport is highly appreciated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
render thread and lua calls (map_add_object_spot for example) can access same refcounters which in case of a race gives crash when counter is decremented more than incremented.
main change is in xr_resource, two other were changed just in case because they use same pattern.