Rewrite of vanilla scripts to use engine iterators for alife objects#247
Draft
themrdemonized wants to merge 3 commits intoall-in-one-vs2022-wpofrom
Draft
Rewrite of vanilla scripts to use engine iterators for alife objects#247themrdemonized wants to merge 3 commits intoall-in-one-vs2022-wpofrom
themrdemonized wants to merge 3 commits intoall-in-one-vs2022-wpofrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of hardcoded for loop to 65534 or 65535, scripts use
alife():iterate_objects_without_actor(function(se_obj))orfor obj in game_objects_without_actor_iter() doSuggestion:
From quick test, the
trans_outfit.scripthas functiontransparent_gg(). The alife iteration causes noticeable lag for some reason. I replaced with game objects iterator to optimize it.Since it caused a lag, maybe instead of object iterator, use for loop with max id.
For example
for i = 1, alife():max_id() - 1 do