fix: correct method calls in Modal show() and hide() methods #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where isHidden and isVisible were called as properties instead of methods. This was causing the conditions to always evaluate to truthy (function reference) instead of the actual boolean return value. Changes: - this.isHidden -> this.isHidden() - this.isVisible -> this.isVisible()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical bug in the Modal component where
isHiddenandisVisiblewere being called as properties instead of methods.Bug Details
In the
show()andhide()methods, the code was checking:if (this.isHidden)instead ofif (this.isHidden())if (this.isVisible)instead ofif (this.isVisible())Since these are methods, calling them without parentheses returns the function reference (which is always truthy), causing the conditions to always evaluate to
true. This means:show()method would always execute its logic, even if the modal was already visiblehide()method would always execute its logic, even if the modal was already hiddenChanges
this.isHidden→this.isHidden()this.isVisible→this.isVisible()Impact
This bug could cause:
Type of Change