forked from alamkanak/Android-Week-View
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace WeekViewEntity
with more versatile WeekViewItem
#272
Draft
thellmund
wants to merge
16
commits into
main
Choose a base branch
from
th/weekViewItem
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thellmund
force-pushed
the
th/weekViewItem
branch
from
December 19, 2021 12:16
7d0beab
to
423c91a
Compare
thellmund
changed the title
Replace WeekViewEntity with more versatile WeekViewItem
Replace Dec 19, 2021
WeekViewEntity
with more versatile WeekViewItem
thellmund
force-pushed
the
th/weekViewItem
branch
3 times, most recently
from
December 24, 2021 09:32
4363be5
to
c24d73e
Compare
thellmund
force-pushed
the
th/weekViewItem
branch
from
January 27, 2022 02:35
7dcbd05
to
420a19e
Compare
thellmund
force-pushed
the
th/weekViewItem
branch
from
April 15, 2022 04:24
21dcd4f
to
db653f3
Compare
Use onEventClick(data, bounds) from now on.
This is more extensible for the date library modules.
thellmund
force-pushed
the
th/weekViewItem
branch
from
April 15, 2022 04:27
db653f3
to
b61569a
Compare
thellmund
force-pushed
the
th/weekViewItem
branch
from
April 15, 2022 14:41
5a4695f
to
b3b5e8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the sealed class
WeekViewEntity
(with its subclassesEvent<T>
andBlockedTime
) with a more versatileWeekViewItem
.WeekViewItem
is a single data class. Instead of using the limited number of subclasses, all information required to correctly render an item are passed as parameters:style
: This is pretty much a copy ofWeekViewEntity.Style
. However, because adapters have access toContext
, the newWeekViewItem.Style
takes only resolved colors and dimensions. You can’t pass in a resource ID anymore.configuration
: This parameter encapsulates various configuration points. Most importantly,configuration.arrangement
can be used to specify whether an item should be rendered in the foreground or background.duration
: This property makes the distinction between all-day and bounded events more explicit. Bounded events have a start and end time, while all-day events only have a date.