Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional drawers #208

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RemiNV
Copy link

@RemiNV RemiNV commented Nov 28, 2020

Additional drawers allow users to customize the appearance of the
calendar by drawing additional items on any layer (background, on
top of the grid, on top of everything, etc).

This allows supporting customization use-cases that are too
uncommon to implement and support in the base library.

Addresses #207

@RemiNV
Copy link
Author

RemiNV commented Nov 28, 2020

To provide clients with enough information to draw their stuff I added a DrawBounds interface that provides a subset of the ViewState, and added an argument to Drawer for the bounds.
Also renamed the existing Drawer to DrawerInternal for that, I think this can also be avoided by using different naming.

@thellmund
Copy link
Owner

Will have a closer look at this soon. Can you add a new Activity to the sample app that uses this functionality? I’d love to see what it looks like and what the use cases would be.

@RemiNV
Copy link
Author

RemiNV commented Dec 7, 2020

Sure, will try to do that when I get the time.

RemiNV added 2 commits January 9, 2021 21:44
Additional drawers allow users to customize the appearance of the
calendar by drawing additional items on any layer (background, on
top of the grid, on top of everything, etc).

This allows supporting customization use-cases that are too
uncommon to implement and support in the base library.
The sample activity demonstrates a drawer on top of the grid that draws
dashed lines at the 30 minute marks for each hour, and a drawer on top
of the whole view that draws a big "Sample" text.
@RemiNV
Copy link
Author

RemiNV commented Jan 9, 2021

Just updated the PR with a commit adding a sample activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants