DEV-16535: Add is-land to quire figures, quire-figure.webc regression fixes#893
Closed
anderspollack wants to merge 25 commits intomainfrom
Closed
DEV-16535: Add is-land to quire figures, quire-figure.webc regression fixes#893anderspollack wants to merge 25 commits intomainfrom
is-land to quire figures, quire-figure.webc regression fixes#893anderspollack wants to merge 25 commits intomainfrom
Conversation
anderspollack
added a commit
to thegetty/quire-starter-default
that referenced
this pull request
Jan 30, 2024
…f individual items
…h image sequences is figured out
Contributor
Author
|
@geealbers these fixes should all be good to go -- I had to do some corresponding style work on thegetty/quire-starter-default#42 to account for the new DOM structure from the |
anderspollack
changed the title
canvasPanel and imageServiceis-land to quire figures, quire-figure.webc regression fixes
anderspollack
changed the title
is-land to quire figures, quire-figure.webc regression fixesis-land to quire figures, quire-figure.webc regression fixes
mphstudios
reviewed
Mar 4, 2024
cbutcosk
added a commit
to cbutcosk/quire
that referenced
this pull request
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
addWebcShortcodea default value forattributeNamesargumentis-landto 3.0.2formats: false<is-land>Fixed
elements are being adding before and after
DEV-16773