Feature: Add q-search-results-list web component.#1193
Conversation
|
Ahead of the code review, this is looking really good @fchasen. It's exciting to see it in action. The two small style changes I'd make are: .search-subresults {
margin-left: 3rem;
}
.result-excerpt mark {
background-color: var(--highlight-color, #F9F9A3);
}Following the pattern of how you handled the other color items, the highlight it based on an as-yet non-existent css variable, but falls back to the highlight color value currently defined in I also played around with doing something to indicate that the excerpts are excerpts, but ultimately it felt too busy for me and probably unnecessary. .result-excerpt:before {
content: '... ';
}
.result-excerpt:after {
content: ' ...';
}Finally, on a non-style note, can we change the display of information on the figure image results? We may have spoken about this before and I thought otherwise, but now that I'm seeing it more in action we can eliminate the page title (I don't think it's clear what it is). And while you have the figure |
Description
Implements a new
q-search-results-listweb component to display and manage the searching a Pagefind index, replacing the current search results template and display logic.queryattribute to search for in a Pagefind index.updateSearchResultsanddisplaySearchResultsmethods, as lit will handle batching UI updates.Checklist
I have read the CONTRIBUTING.md file
I have made my changes in a new branch and not directly in the main branch
This pull request is ready for final review by the Quire team
Include screenshots of before/after if applicable.
Additional Comments
Thumbnail handling for figures will be added once they are a size that can be used.