Conversation
Erin-Cecele
left a comment
There was a problem hiding this comment.
This is approved, but so I understand, we really only want to use name if it's one author? If it's more than one we should use string? And if name is used for more than one author, will they all appear just not with the correct comma usage?
Also, so weird that the deploy instructions were wrong. Alba just went through and confirmed all of that two months ago. After our conversation about changes to GitHub (new issue labels, etc.) I realized I should see if I can sign up for a "new features" newsletter or something.
|
Disregard my comment about the deploy instructions being wrong. I see the change was more for consistency's sake! |
|
@Erin-Cecele whenever you get a chance, I pushed an edit to the |
Thank you for contributing to the Quire Documentation & Website! Please complete the form below to submit your pull request for review.
For the Title of this pull request, please use the format "Type/Issue-#: Brief description." For Type, the options are Edit, Add, Translate. Issue-# is only needed if this pull request addresses an existing issue.
Checklist
Please put an X within the brackets that apply
[X].I have read the CONTRIBUTING.md file.
I have made my changes in a new branch and not directly in the main branch
I am requesting feedback on a draft pull request
Is this pull request related to an open issue? If so, what is the issue number?
No
Please describe the goal of this pull request and the changes that were made.
Doing two small things here:
Updating the possible values for
bylineFormatper this issue from GRJ 21: https://github.com/thegetty/grj-21/issues/34. I also submitted a PR toquire-starter-defaultto make the update there as well.Our instructions for GitHub deploy erroneously uses two different branch names (
gh-deployandgh-pages). It can work with any name, but it has to be consistent. I went withgh-pagesas it's the traditionally used name for gh pages deploys.Additional Comments