Fixes #37897 - Separate autosign key generation and configuration #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bastian-src
commented
Oct 9, 2024
bastian-src
commented
- Replace the update of salt_autosign_key with setting the field after_validation to guarantee that the host is not updated during deployment
- Move the API calls, configuring the autosign key on the corresponding proxy, to an additional orchestration stage to make it visible to the user and reduce delay during validation/saving.
bastian-src
force-pushed
the
fix/issue_37897_host_update_during_deployment
branch
8 times, most recently
from
1152b64 to
f99f707
Compare
bastian-src
force-pushed
the
fix/issue_37897_host_update_during_deployment
branch
from
f99f707 to
40ebbf9
Compare
nadjaheitmann
approved these changes
Oct 14, 2024
* Replace the update of salt_autosign_key with setting the field after_validation to guarantee that the host is not updated during deployment * Move the API calls, configuring the autosign key on the corresponding proxy, to an additional orchestration stage to make it visible to the user and reduce delay during validation/saving. Co-authored-by: Nadja Heitmann <[email protected]>
bastian-src
force-pushed
the
fix/issue_37897_host_update_during_deployment
branch
from
bb2f85d to
d7c76fb
Compare
|
Thanks for the review @nadjaheitmann! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.