Skip to content

Conversation

@MartinSpiessl
Copy link

This adds a playbook/remote execution feature to upgrade an orcharhino Proxy. It also ensures that the distinction between Foreman, Satellite, and orcharhino is properly made everywhere where the proxy upgrade feature is used.

Overview of Changes

  • add a playbook/job template/remote execution feature for updating orcharhino Proxies

Implementation Considerations

  • Will not affect Smart Proxy or Capsule installations
  • Unify behavior to work nicely for all 3 proxy brandings

Testing Steps

  • Test setup: a orcharhino/Foreman/Satellite with foreman_ansible from this PR with a proxy (smart proxy/orcharhino Proxy/Capsule) that is on an outdated foreman version
  • with the changes in this PR, the following will also work for orcharhino:
  • If the foreman version of the proxy is outdated, the upgrade button appears in the proxy overview page (/smart_proxies) and on the proxy detail page as action(/smart_proxies/) on the webpage and triggers the upgrade playbook; the upgrade playbook can also be executed manually as remote execution

Checklists

  • I am familiar with the contributing guidelines.
  • I have added relevant tests for my changes.
    • => current upgrade functionality has no tests, so I assume it is fine if I do not touch testing files (I would need help with how this should be tested)
  • I have updated the documentation accordingly.
    • => this will only affect orcharhino documentation

Additional Notes

This adds a playbook/remote execution feature to upgrade an orcharhino Proxy.
It also ensures that the distinction between Foreman, Satellite, and orcharhino
is properly made everywhere where the proxy upgrade feature is used.
Copy link
Contributor

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @MartinSpiessl for this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants