Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPM] Update kafo to 2.1.0 #1988

Merged
merged 1 commit into from
Jan 22, 2018
Merged

[RPM] Update kafo to 2.1.0 #1988

merged 1 commit into from
Jan 22, 2018

Conversation

ares
Copy link
Member

@ares ares commented Dec 18, 2017

For plugin updates, please indicate which repos this should be built into:

  • Nightly
  • 1.16
  • 1.15
  • 1.14

See Foreman's plugin maintainer documentation for more information.


@ares ares changed the title Update kafo to 2.1.0 [RPM] Update kafo to 2.1.0 Dec 18, 2017
@mmoll
Copy link

mmoll commented Dec 18, 2017

blocked on voxpupuli/puppet-extlib#89

@mmoll
Copy link

mmoll commented Dec 18, 2017

and voxpupuli/puppet-staging#150

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(testing the PR processor)

@ekohl
Copy link
Member

ekohl commented Jan 3, 2018

Finally got around to creating voxpupuli/puppet-staging#152

@ehelms
Copy link
Member

ehelms commented Jan 10, 2018

This y-release of Kafo requires that all puppet modules support Puppet 5?

@ekohl
Copy link
Member

ekohl commented Jan 10, 2018

Correct - it verifies the OS is listed in metadata.json and the running puppet version matches the constraints. The current issue is that puppetlabs-mysql doesn't allow puppet-staging 3.0. We need puppetlabs/puppetlabs-mysql@c5eb9ba to be in a released version. I haven't checked how it handles modules without a puppet metadata version (https://github.com/jlambert121/jlambert121-trusted_ca/blob/master/metadata.json - used in Katello) but I'm leaning to forking that anyway (jlambert121/jlambert121-trusted_ca#37).

@ares
Copy link
Member Author

ares commented Jan 11, 2018

This y-release of Kafo requires that all puppet modules support Puppet 5?

I don't think that's a fair summary. Kafo 2.1 added a feature to parse module metadata and validate the module can be used by the puppet that's used. There's a --skip-puppet-version-check for disabling it. See this for more details theforeman/kafo#213 in fact it let us know about possible incompatibilities that we ignored so far.

@ekohl
Copy link
Member

ekohl commented Jan 11, 2018

@mmoll
Copy link

mmoll commented Jan 21, 2018

to be merged together with theforeman/foreman-installer#256

@ekohl ekohl merged commit 80d9030 into theforeman:rpm/develop Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants