Update to support EventBus7 #129

Chidoziealways · 2025-07-12T17:21:48Z

Updated KotlinForForge to support MC 1.21.7 and the new EventBus7 introduced in Forge 57.x.
Mod containers now use BusGroup for event dispatching, keeping up with the Forge changes.

thedarkcolour · 2025-07-12T21:49:47Z

Do old Forge versions (1.21.1-1.21.5) use EB7? This could be a breaking change that I don't want to merge into KFF 6.x

Chidoziealways · 2025-07-13T05:25:49Z

But, it also breaks support for MC 1.21.6-1.21.7
5.x and below can use EB6 but 6.x should use EB7

thedarkcolour

I'll review the KotlinModContainer class later, I'm suspicious of the module reflection, but knowing LexForge, it's probably just how they decided to do it...

thedarkcolour · 2025-07-13T05:34:52Z

gradle.properties

Why all of these random Gradle options? If these changes are just for your setup, please remove them from the PR

thedarkcolour · 2025-07-13T05:35:06Z

gradle.properties


 # KOTLIN FOR FORGE VERSION
-kff_version=5.9.0
-kff_max_version=6.0.0


This should be 7.0.0, not 6.1.0

I've changed that

thedarkcolour · 2025-07-13T05:36:25Z

src/kfflang/forge/kotlin/thedarkcolour/kotlinforforge/AutoKotlinEventBusSubscriber.kt

    private fun registerTo(any: Any, target: Mod.EventBusSubscriber.Bus, mod: KotlinModContainer) {
        if (target == Mod.EventBusSubscriber.Bus.FORGE) {
-            target.bus().get().register(any)
+            target.bus().get()?.register(MethodHandles.lookup(), any)


Why is the bus supplier now nullable? Should this log an error if the bus is null?

Should I use !! or ?

The compiler 2.2.0 won't let me go without !! or ?

thedarkcolour · 2025-07-13T05:37:16Z

.../forge/resources/META-INF/services/net.minecraftforge.forgespi.language.IModLanguageProvider

Please remove this change from the PR

Chidoziealways · 2025-07-13T07:24:37Z

Is it ok now?

Chidoziealways · 2025-07-13T15:23:14Z

ok

…

On Sun, Jul 13, 2025 at 6:39 AM thedarkcolour ***@***.***> wrote: ***@***.**** requested changes on this pull request. I'll review the KotlinModContainer class later, I'm suspicious of the module reflection, but knowing LexForge, it's probably just how they decided to do it... ------------------------------ On gradle.properties <#129 (comment)> : Why all of these random Gradle options? If these changes are just for your setup, please remove them from the PR ------------------------------ In gradle.properties <#129 (comment)> : > min_mc_version = 1.20.6 unsupported_mc_version = 1.22 # KOTLIN FOR FORGE VERSION -kff_version=5.9.0 -kff_max_version=6.0.0 This should be 7.0.0, not 6.1.0 ------------------------------ In src/kfflang/forge/kotlin/thedarkcolour/kotlinforforge/AutoKotlinEventBusSubscriber.kt <#129 (comment)> : > @@ -132,9 +133,9 @@ public object AutoKotlinEventBusSubscriber { private fun registerTo(any: Any, target: Mod.EventBusSubscriber.Bus, mod: KotlinModContainer) { if (target == Mod.EventBusSubscriber.Bus.FORGE) { - target.bus().get().register(any) + target.bus().get()?.register(MethodHandles.lookup(), any) Why is the bus supplier now nullable? Should this log an error if the bus is null? ------------------------------ On src/kfflang/forge/resources/META-INF/services/net.minecraftforge.forgespi.language.IModLanguageProvider <#129 (comment)> : Please remove this change from the PR — Reply to this email directly, view it on GitHub <#129 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BK6AZOOB5WOF5UYTEULFC733IHWK5AVCNFSM6AAAAACBL6TRCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMJTHA4DCOJSGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Chidoziealways · 2025-07-14T15:36:28Z

I'm not yet done with the update. Still testing and making changes

Chidoziealways · 2025-07-14T16:05:51Z

Currently fighting with EventBusSubscriber firing too late for our likings

thedarkcolour · 2025-07-14T16:16:47Z

I can also take a look at it after I'm back from work.

Chidoziealways · 2025-07-14T16:19:25Z

As of now, all Events to be automatically registered need to be @SubscriveEvent and @JvmStatic

…scribers. ADDED ACTUAL EVENT FIRING AND MANY MORE

Chidoziealways · 2025-07-16T06:21:25Z

Ok. Done with the PR. DOne with the commits, done with the updating. All that's left is for you to merge. Everything WOrks perfectly fine

Chidoziealways · 2025-07-16T06:35:42Z

Or can I upload to curseforge?? and modrinth?? PLS

Chidoziealways · 2025-07-16T07:14:05Z

Right Now, All EventBusSubscriber classes have to use KotlinEventBusSubscriber, all Mod KotlinMod all Bus KotlinBus and the @subscribe methods should NOT have @JvmStatic

Chidoziealways · 2025-07-16T07:14:41Z

until you publish the changes to curseforge I'll embed them

thedarkcolour · 2025-07-17T18:12:10Z

Gonna look this over in a few hours.

Chidoziealways · 2025-07-21T08:32:03Z

um, did you forget about this?

thedarkcolour · 2025-07-21T15:07:28Z

Sorry, I have not had time. I'm not ignoring it though

thedarkcolour · 2025-08-29T06:57:38Z

src/kfflang/forge/kotlin/thedarkcolour/common/KotlinMod.kt

Why are we now using @KotlinMod instead of @mod?

To make it easier to distinguish, because the @mod annotation is part of the FML Loader, and it would be easier for KFF to have it's own annotation, as it's a separate loader.

thedarkcolour · 2025-08-29T06:58:16Z

src/kfflang/forge/kotlin/thedarkcolour/kotlinforforge/KotlinLanguageProvider.kt

No emojis in the log messages. This is not an AI-generated mod.

thedarkcolour · 2025-08-29T06:58:43Z

src/kfflang/forge/kotlin/thedarkcolour/kotlinforforge/KotlinLanguageProvider.kt

    }

    private companion object {
-        private val MOD_ANNOTATION = Type.getType("Lnet/minecraftforge/fml/common/Mod;")


Again, what's up with the separate annotation?

thedarkcolour · 2025-08-29T07:00:55Z

I will give this a more careful review sooner, I have yet to test this in-game.

Chidoziealways · 2025-10-01T14:37:34Z

are those really conflicts? or should I not change the versions? Latest Kotlin is 2.2.20

Chidoziealways · 2025-10-01T14:38:43Z

and then, 1.21.9 is out so I need to update again, so new version is 6.1.0?

Update to support EventBus7

ee773cb

Chidoziealways added 2 commits July 13, 2025 06:15

Finished Updating to Kotlin P1

bad92ba

Finished Updating to Kotlin P2

f908362

thedarkcolour requested changes Jul 13, 2025

View reviewed changes

Chidoziealways added 2 commits July 13, 2025 08:11

Finished Updating to Kotlin P3 FINISHED

19a2464

Made required changes

9233794

Chidoziealways added 2 commits July 13, 2025 08:40

removed unnecesary gradle properties

1eac749

Continued update

3be40d8

Finished Update to 1.21.7 EventBus 7 Forge 1.21.7-57.0.2

02e70ea

FINISHED UPDATING TO 1.21.7-57.0.2 ADDED REAL SUPPORT FOR EventBusSUb…

337172a

…scribers. ADDED ACTUAL EVENT FIRING AND MANY MORE

Chidoziealways requested a review from thedarkcolour August 26, 2025 09:33

blackd mentioned this pull request Aug 29, 2025

class loading errors? #134

Open

thedarkcolour reviewed Aug 29, 2025

View reviewed changes

Update to support EventBus7 #129

Are you sure you want to change the base?

Update to support EventBus7 #129

Uh oh!

Conversation

Chidoziealways commented Jul 12, 2025

Uh oh!

thedarkcolour commented Jul 12, 2025

Uh oh!

Chidoziealways commented Jul 13, 2025

Uh oh!

thedarkcolour left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chidoziealways commented Jul 13, 2025

Uh oh!

Chidoziealways commented Jul 13, 2025 via email

Uh oh!

Chidoziealways commented Jul 14, 2025

Uh oh!

Chidoziealways commented Jul 14, 2025

Uh oh!

thedarkcolour commented Jul 14, 2025

Uh oh!

Chidoziealways commented Jul 14, 2025

Uh oh!

Chidoziealways commented Jul 16, 2025

Uh oh!

Chidoziealways commented Jul 16, 2025

Uh oh!

Chidoziealways commented Jul 16, 2025

Uh oh!

Chidoziealways commented Jul 16, 2025

Uh oh!

thedarkcolour commented Jul 17, 2025

Uh oh!

Chidoziealways commented Jul 21, 2025

Uh oh!

thedarkcolour commented Jul 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thedarkcolour commented Aug 29, 2025

Uh oh!

Chidoziealways commented Oct 1, 2025

Uh oh!

Chidoziealways commented Oct 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants