Update tdbm for Symfony 6 and doctrine v3 #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/TDBMService.php
Outdated
| @@ -26,7 +26,7 @@ | |||
| use Doctrine\Common\Cache\ClearableCache; | |||
| use Doctrine\Common\Cache\VoidCache; | |||
| use Doctrine\DBAL\Connection; | |||
| use Doctrine\DBAL\DBALException; | |||
| use Doctrine\DBAL\Exception; | |||
There was a problem hiding this comment.
Maybe prefer an alias to show that it comes from DBAL:
Suggested change
| use Doctrine\DBAL\Exception; | |
| use Doctrine\DBAL\Exception as DBALException; |
| @@ -19,22 +19,21 @@ | |||
| ], | |||
| "require" : { | |||
| "php": "^7.4 || ^8.0", | |||
| "mouf/magic-query": "^1.4.3", | |||
| "mouf/magic-query": "2.0.x-dev", | |||
There was a problem hiding this comment.
Once everything works:
- Merge changes to
mouf/magic-queryif there are any - Release a new
mouf/magic-queryversion (2.0.0) - Require this new version here
daetcm
force-pushed
the
updates-for-sf6
branch
2 times, most recently
from
5a843fa to
a138b5b
Compare
daetcm
force-pushed
the
updates-for-sf6
branch
from
a138b5b to
5422ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.