Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

Thecodingmachine master #33

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ConradKurth
Copy link

A similar PR may already be submitted!
Please search among the pull requests before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

For more information, see the CONTRIBUTING guide.

Summary

This PR fixes/implements the following bugs/features

  • Bug 1
  • Bug 2
  • Feature 1
  • Feature 2
  • Breaking changes

Explain the motivation for making this change. What existing problem does the pull request solve?

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output.

Closing issues

Fixes #

Checklist

  • Have you followed the guidelines in our CONTRIBUTING guide?
  • Have you lint your code locally prior to submission (make lint)?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally (make tests)?
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@@ -20,7 +20,7 @@ func (req *HTMLRequest) Assets(assets ...Document) {
}

func (req *HTMLRequest) postURL() string {
return "/convert/html"
return "/forms/chromium/convert/html"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This will work with gotenberg API docker iamge v7, but is not backward compatible with v6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants