translator: limit the amount of nodes processed by the jsonschema helper - #2774
Merged
Merged
Conversation
Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
✅ Deploy Preview for theagentrouter canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nacx
enabled auto-merge (squash)
October 2, 2026 03:27
NotAFlightRisk
approved these changes
Oct 2, 2026
mathetake
approved these changes
Oct 2, 2026
Contributor
|
@nacx Hi, just curious, do we still need to maintain the codes for the workaround? These codes are for models of gemini2.0x, and they're retired? After gemini-2.5, we can directly use json_schema? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Limit the number of nodes processed by the JSON schema helper. A limit existed for the depth, not for the number of sibling nodes or lists that are processed.
Also add a small change to return a proper 422 error instead of a 500 for these invalid requests.
Related Issues/PRs (if applicable)
N/A
Special notes for reviewers (if applicable)
N/A