-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous MUI styling fixes #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick scan file changes, looks innocuous enough :-) next step is for me to check the build itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, it looks OK and there are no console errors I see. @benloh is the one who wrote the initial issue up so should be the final arbiter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that SVG elements are displayed in the right position and that warnings are no longer present.
This PR addresses two issues:
Testing
Developer Notes
The fixed issues are related to MUI components that were partially migrated from MUI v4 to v5. These changes revolve around including the
styled
utility, properly wrapping components to inject styles, and misc. styling fixes to accommodate other changes.