Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous MUI styling fixes #24

Merged
merged 11 commits into from
Jun 19, 2024
Merged

Miscellaneous MUI styling fixes #24

merged 11 commits into from
Jun 19, 2024

Conversation

Sakelun
Copy link
Collaborator

@Sakelun Sakelun commented Jun 18, 2024

This PR addresses two issues:

Testing

  1. Prepare your local environment as described in the project's README (package installation, node version selection, etc.)
  2. Launch MEME's Admin panel and create a group with two users (to test Comment read styling)
  3. Log in with the first user you created.
  4. Create some new entities and outcomes. Refresh the page and do the same. Note that they appear on page. This tests the behavior reported in New outcome/entity is displayed offscreen #7.
  5. Create a few new comments. Note that there are no warnings in the console when doing so. This tests the behavior reported in Opening a new project comment warnings  #5.
  6. Open a separate browser window and log in as the second user that you created.
  7. Look at the Comment button in the toolbar, it should have a "unread" state (it will look like a chat bubble with text).
  8. Open the comments
  9. Note that the Comment button switches to a solid filled chat bubble indicating that the comments have been read.

Developer Notes

The fixed issues are related to MUI components that were partially migrated from MUI v4 to v5. These changes revolve around including the styled utility, properly wrapping components to inject styles, and misc. styling fixes to accommodate other changes.

@Sakelun Sakelun requested review from benloh and dsriseah June 18, 2024 19:22
@Sakelun
Copy link
Collaborator Author

Sakelun commented Jun 18, 2024

Hey @benloh, @dsriseah

Claimfixed: #5, #7

This PR does some MUI styling component conversions which may overlap or be rendered unnecessary by your recent decision to move off of MUI entirely.

Copy link

@dsriseah dsriseah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick scan file changes, looks innocuous enough :-) next step is for me to check the build itself.

Copy link

@dsriseah dsriseah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, it looks OK and there are no console errors I see. @benloh is the one who wrote the initial issue up so should be the final arbiter.

@Sakelun Sakelun changed the title DRAFT: Miscellaneous MUI styling fixes Miscellaneous MUI styling fixes Jun 18, 2024
Copy link

@benloh benloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that SVG elements are displayed in the right position and that warnings are no longer present.

@benloh benloh merged commit 067824d into dev Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New outcome/entity is displayed offscreen Opening a new project comment warnings
5 participants